feat: Show warning for unused properties #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoliy Bazko <[email protected]>
tolusha
requested review from
AndrienkoAleksandr,
l0rd and
mmorhun
as code owners
46 tasks
Signed-off-by: Anatoliy Bazko <[email protected]>
mmorhun
approved these changes
Feb 21, 2020
AndrienkoAleksandr
approved these changes
Feb 21, 2020
sleshchenko
reviewed
Feb 21, 2020
sleshchenko
reviewed
Feb 24, 2020
src/commands/server/start.ts
Outdated
| msg += flags['self-signed-cert'] ? '\t--self-signed-cert' : '' | ||
| msg += flags['os-oauth'] ? '\t--os-oauth' : '' | ||
| msg += flags.tls ? '\t--ls' : '' | ||
| msg += flags.cheimage ? '\t--cheimage' : '' |
There was a problem hiding this comment.
It's not critical but cheimage is printed even when user does not specify it.
| @@ -186,6 +186,23 @@ export default class Start extends Command { | |||
|
|
|||
| checkPlatformCompatibility(flags: any) { | |||
| // matrix checks | |||
| if (flags.installer === 'operator' && flags['che-operator-cr-yaml']) { | |||
There was a problem hiding this comment.
Is it actual also when user use --che-operator-cr-patch-yaml?
Signed-off-by: Anatoliy Bazko <[email protected]>
Signed-off-by: Anatoliy Bazko <[email protected]>
Signed-off-by: Anatoliy Bazko <[email protected]>
Signed-off-by: Anatoliy Bazko <[email protected]>
Signed-off-by: Anatoliy Bazko <[email protected]>
tolusha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anatoliy Bazko [email protected]
What does this PR do?
Show warning for unused properties
What issues does this PR fix or reference?
eclipse-che/che#15072