Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support creating workspaces with a workspace config JSON #34

Merged
merged 5 commits into from
Dec 31, 2018

Conversation

l0rd
Copy link
Collaborator

@l0rd l0rd commented Dec 31, 2018

$ chectl workspace:start --help
(...)
  -w, --workspaceconfig=workspaceconfig  path to a valid workspace configuration json file

@l0rd l0rd requested a review from azatsarynnyy December 31, 2018 02:32
}
} catch (error) {
if (!workspaceConfig) { throw new Error(`E_NOT_FOUND_WORKSPACE_CONFIG_FILE - ${workspaceConfigPath} - ${error.message}`) }
if (error.response && error.response.status && error.response.status === 400) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error.response.status check can be omitted here

@l0rd l0rd merged commit f361c31 into che-incubator:master Dec 31, 2018
@l0rd l0rd deleted the addworkspaceconfig branch December 31, 2018 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants