Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e tests, task title #2858

Merged
merged 1 commit into from
Feb 6, 2024
Merged

fix: e2e tests, task title #2858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,10 @@ jobs:
fi
- name: Run make-release.sh script (commit changes, create branch, create PR)
run: |
# since we're using Flavius' token below to generate PRs, should also make tags/branches/commits by same owner
# since we're using Bazko' token below to generate PRs, should also make tags/branches/commits by same owner
# see https://github.com/che-incubator/chectl/settings/secrets/actions for the token used
git config --global user.name "Flavius Lacatusu"
git config --global user.email "flacatus@redhat.com"
git config --global user.name "Anatolii Bazko"
git config --global user.email "abazko@redhat.com"
export GITHUB_TOKEN=${{ secrets.CHE_INCUBATOR_BOT_GITHUB_TOKEN }}
DWO_VERSION=${{ github.event.inputs.devworkspaceOperatorVersion }}
if [[ -z ${DWO_VERSION} ]]; then
Expand Down
2 changes: 1 addition & 1 deletion src/tasks/installers/eclipse-che/eclipse-che-tasks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ export namespace EclipseCheTasks {
ctx[OperatorImageUpgradeContext.NEW_IMAGE_NAME] = newImage
ctx[OperatorImageUpgradeContext.NEW_IMAGE_TAG] = newTag

task.title = `${task.title} ${ctx[OperatorImageUpgradeContext.NEW_IMAGE_TAG]} -> ${ctx[OperatorImageUpgradeContext.DEPLOYED_IMAGE_TAG]}`
task.title = `${task.title} ${ctx[OperatorImageUpgradeContext.DEPLOYED_IMAGE_TAG]} -> ${ctx[OperatorImageUpgradeContext.NEW_IMAGE_TAG]}`
},
}
}
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/e2e-upgrade-version.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ describe('Test Che upgrade', () => {
const binChectl = E2eHelper.getChectlBinaries()
// scale deployments down to free up some resources
await helper.runCliCommand('kubectl', ['scale', 'deployment', 'che', '--replicas=0', `-n ${NAMESPACE}`])

await helper.runCliCommand(binChectl, ['server:update', '-y', `-n ${NAMESPACE}`, '--telemetry=off'])
await helper.runCliCommand(binChectl, ['server:start', `-n ${NAMESPACE}`, '--telemetry=off'])
await helper.waitForCheServerImageTag(helper.getNewVersion(), UPDATE_CHE_TIMEOUT_MS)
})

Expand Down
Loading