use latest node 18.18.0 in workflows #2783
Conversation
Change-Id: Id9133f0e7f6bb738f8625fd3bdc79730df6a004e Signed-off-by: Nick Boldt <[email protected]> bump copyrights Change-Id: I3bc89c21ae5b5255559684ff9682564aa7729bcf Signed-off-by: Nick Boldt <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nickboldt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nickboldt
changed the title
| @@ -23,7 +23,7 @@ jobs: | |||
| persist-credentials: false | |||
| - uses: actions/setup-node@v3 | |||
| with: | |||
| node-version: 18.16.1 | |||
| node-version: 18.18.0 | |||
There was a problem hiding this comment.
maybe it makes sense to try 18.15 version if the bug is still not fixed in the che-code?
There was a problem hiding this comment.
maybe but we're using 18.16.1 downstream in 3.9 ... https://github.com/redhat-developer/devspaces/blob/devspaces-3-rhel-8/dependencies/job-config.json#L655-L657 ... https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/DS_CI/job/dsc_3.9/ and that works OK
|
Build 3.10 :: dsc_3.x/1466: Console, Changes, Git Data |
|
Build 3.10 :: dsc_3.x/1466: 3.10.0-CI |
What does this PR do?
use latest node 18.18.0 in workflows
Change-Id: Id9133f0e7f6bb738f8625fd3bdc79730df6a004e
Signed-off-by: Nick Boldt [email protected]
bump copyrights
Change-Id: I3bc89c21ae5b5255559684ff9682564aa7729bcf
Signed-off-by: Nick Boldt [email protected]
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
none; this might also be unsafe due to microsoft/vscode#194665
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.