fix(platform): server:start with specified domain #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergii Leshchenko <[email protected]>
sleshchenko
requested review from
azatsarynnyy,
l0rd,
rhopp and
vparfonov
as code owners
|
waiting target milestone of referenced issue |
sleshchenko
changed the title
|
@benoitf Do you think it makes sense to enable WIP bot for chectl repo? |
|
@sleshchenko done |
benoitf
approved these changes
Aug 1, 2019
23 tasks
|
@benoitf @sleshchenko are you planning to merge it before or after GA ? |
|
@ibuziuk Since the referenced issue is labeled with 7.0.0 milestone, I can merge it right now. |
sleshchenko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Do not ignore the domain parameter if it's specified.
What issues does this PR fix or reference?
eclipse-che/che#14095