-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt chectl to fixes for TLS for helm chart #237
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleshchenko
requested review from
azatsarynnyy,
benoitf,
l0rd,
rhopp and
vparfonov
as code owners
July 26, 2019 06:18
I am on PTO I won't able to test it today. Will be back on Monday but feel free to merge it if it gets approved before. |
benoitf
reviewed
Jul 26, 2019
FYI semantic commits and DCO checks are failing |
(see CONTRIBUTING.MD) |
benoitf
approved these changes
Jul 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on GCP
Signed-off-by: Sergii Leshchenko <[email protected]>
l0rd
reviewed
Jul 29, 2019
Signed-off-by: Sergii Leshchenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
TODO revise
--chenamespace=chenamespace
parameter--tls
does not enable multiuser anymore.multi-host
and it requires wildcards certificates. It's why helm chart does not include cluster issuer and certificates anymore. User must provideche-tls
secret with certificate content.It's why checking that cert-manager is set is removed, as well as propagating
tls.email
parameter.It's tested on GCP with the following configurations:
What issues does this PR fix or reference?
It's needed after eclipse-che/che#13946