Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt chectl to fixes for TLS for helm chart #237

Merged
merged 2 commits into from
Jul 30, 2019

Conversation

sleshchenko
Copy link
Contributor

@sleshchenko sleshchenko commented Jul 26, 2019

What does this PR do?

TODO revise --chenamespace=chenamespace parameter

  1. Fixes documentation since --tls does not enable multiuser anymore.
  2. The only server strategy that works is multi-host and it requires wildcards certificates. It's why helm chart does not include cluster issuer and certificates anymore. User must provide che-tls secret with certificate content.
    It's why checking that cert-manager is set is removed, as well as propagating tls.email parameter.

It's tested on GCP with the following configurations:

./bin/run server:start -a=helm -p=k8s -b=che.gcps.my-ide.cloud --tls --multiuser
./bin/run server:start -a=helm -p=k8s -b=che.gcps.my-ide.cloud --tls
./bin/run server:start -a=helm -p=k8s -b=che.gcps.my-ide.cloud --multiuser

What issues does this PR fix or reference?

It's needed after eclipse-che/che#13946

@l0rd
Copy link
Collaborator

l0rd commented Jul 26, 2019

I am on PTO I won't able to test it today. Will be back on Monday but feel free to merge it if it gets approved before.

src/installers/helm.ts Outdated Show resolved Hide resolved
@benoitf
Copy link
Collaborator

benoitf commented Jul 26, 2019

FYI semantic commits and DCO checks are failing

@benoitf
Copy link
Collaborator

benoitf commented Jul 26, 2019

(see CONTRIBUTING.MD)

Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on GCP

src/installers/helm.ts Outdated Show resolved Hide resolved
@sleshchenko sleshchenko merged commit 9094ce7 into che-incubator:master Jul 30, 2019
@sleshchenko sleshchenko deleted the tls-fixes branch July 30, 2019 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants