Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix dex configuration, set identity provider in checluster #1864

Merged
merged 2 commits into from
Nov 30, 2021

Conversation

sparkoo
Copy link
Member

@sparkoo sparkoo commented Nov 30, 2021

Signed-off-by: Michal Vala [email protected]

What does this PR do?

  • fixes dex configuration to set oauth callback without subdomain, where che is really deployed
  • sets identity provider url to dex service in checluster CR
  • don't show warning message when native user mode is enabled

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#20635
eclipse-che/che#20810

How to test this PR?

cat EOF << > /tmp/patch.yaml
spec:
  auth:
    nativeUserMode: true
EOF

chectl server:deploy \
     --installer operator \
     --platform minikube \
     --che-operator-image quay.io/mvala/che-operator:gh20635-nativeAuthKube \
     --che-operator-cr-patch-yaml /tmp/patch.yaml

after deploy, install dex certificate into the browser and open che url.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@openshift-ci
Copy link

openshift-ci bot commented Nov 30, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sparkoo, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit 9db7957 into che-incubator:main Nov 30, 2021
@che-bot che-bot added this to the 7.40 milestone Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants