feat: Implement backup and restore commands #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
tolusha
reviewed
Jul 8, 2021
src/api/backup-restore.ts
Outdated
| sshKey: string | ||
| } | ||
|
|
||
| export const BACKUP_CR_NAME = 'chectl-che-backup' |
There was a problem hiding this comment.
why do we need a chectl prefix?
There was a problem hiding this comment.
To be sure we do not override user's CR.
There was a problem hiding this comment.
Also to see that the CR is created by chectl
There was a problem hiding this comment.
It is also user's CR but created with chectl.
if we need to mark CR with something then add this to annotation.
so, pls remove that prefix.
Signed-off-by: Mykola Morhun <[email protected]>
Signed-off-by: Mykola Morhun <[email protected]>
Signed-off-by: Mykola Morhun <[email protected]>
Signed-off-by: Mykola Morhun <[email protected]>
|
Rebased |
tolusha
changed the title
tolusha
approved these changes
Jul 9, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mmorhun, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Morhun [email protected]
What does this PR do?
Add
server:backupandserver:restorecommandsWhat issues does this PR fix or reference?
eclipse-che/che#19932
How to test this PR?
Internal backup server
chectl server:backupand wait until it finisheschectl server:restoreand wait until it finishesAn external backup server
chectl server:backup -r rest:my.server.net:8000/che-backupand wait until it finisheschectl server:restoreand wait until it finishesPR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.