Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove the explicit DWCO (un)installation steps. #1348

Merged
merged 2 commits into from
Jul 6, 2021

Conversation

metlos
Copy link
Contributor

@metlos metlos commented Jun 30, 2021

What does this PR do?

Make sure that DWCO related objects are deleted during che-operator uninstallation instead of devworkspace uninstallation.

This only makes sense when the referenced issues are merged.

What issues does this PR fix or reference?

eclipse-che/che#19402
eclipse-che/che#19847

How to test this PR?

  1. Install Che using the operator
  2. Delete the Che installation using chectl server:delete
  3. Make sure it works OK
    oc get clusterroles | grep devworkspace-che
    oc get roles -n eclipse-che | grep devworkspace-che
    oc get rolebindings -n eclipse-che | grep devworkspace-che
    oc get clusterrolebindings -n eclipse-che | grep devworkspace-che
    
  4. Install Che using the operator again
  5. Enable devworkspaces
    oc patch checluster eclipse-che -n eclipse-che --type=json -p '[{"op": "replace", "path": "/spec/devWorkspace/enable", "value": true}]'
    
  6. Delete the Che installation using chectl server:delete again
  7. Make sure there are no remnants of DWCO using the step 3

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@openshift-ci
Copy link

openshift-ci bot commented Jul 1, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: metlos, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Jul 1, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 1, 2021

New changes are detected. LGTM label has been removed.

metlos added 2 commits July 2, 2021 13:25
Make sure that DWCO related objects are deleted during che-operator
uninstallation instead.
@mmorhun mmorhun force-pushed the bug/19402-dwco-codeployment branch from fe9b84e to c588206 Compare July 2, 2021 10:27
@mmorhun
Copy link
Contributor

mmorhun commented Jul 2, 2021

Rebased

@mmorhun
Copy link
Contributor

mmorhun commented Jul 6, 2021

I've investigated why the e2e update tests tests fails and the problem is not related to the changes in this PR.

@mmorhun mmorhun merged commit 3654e6a into che-incubator:main Jul 6, 2021
@che-bot che-bot added this to the 7.33 milestone Jul 6, 2021
@metlos metlos deleted the bug/19402-dwco-codeployment branch July 7, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants