feat: Add license utility to chectl to validate and add license header to codebase #1278
Conversation
flacatus
requested review from
AndrienkoAleksandr,
l0rd,
mmorhun and
tolusha
as code owners
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: flacatus The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
why not using eslint https://www.npmjs.com/package/eslint-plugin-header ?
IMHO typescript projects should use eslint plug-ins so it's handled in IDE as well
…r to code Signed-off-by: Flavius Lacatusu <[email protected]>
|
@flacatus: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@flacatus @tolusha @benoitf I have another question to discuss. This PR forces all headers to have date |
|
It isn't a problem to update year. |
| @@ -1,6 +1,5 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Maybe for shell script we have to save #!/bin/bash ? I guess they will be broken without this directive...
| @@ -1 +1,14 @@ | |||
| /** | |||
| * | |||
|
Closing in favor of #1280 |
What does this PR do?
This PR add a new automation to chectl to check and add license headers to codebase. Also this PR fix all incorrect license headers.
Refference issue: eclipse-che/che#19647
Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?
Download current branch and execute:
For check release:
To add new license header to a file which doesn't contain a license:
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.