-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove completelly Devworkspace Che-operator when server:delete is executed #1261
Conversation
…ecuted Signed-off-by: Flavius Lacatusu <[email protected]>
@tolusha @mmorhun @AndrienkoAleksandr |
I don't mind. |
src/tasks/component-installers/devfile-workspace-operator-installer.ts
Outdated
Show resolved
Hide resolved
5e280d8
to
c3dcdde
Compare
Signed-off-by: Flavius Lacatusu <[email protected]>
src/tasks/component-installers/devfile-workspace-operator-installer.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Flavius Lacatusu <[email protected]>
Signed-off-by: Flavius Lacatusu <[email protected]>
Signed-off-by: Flavius Lacatusu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flacatus I like the generalization in getCustomResource
, however I would keep old getCheCluster
too with the following implementation:
async getCheCluster(cheNamespace: string) {
return this.kube.getCustomResource(cheNamespace, CHE_CLUSTER_API_GROUP, CHE_CLUSTER_API_VERSION, CHE_CLUSTER_KIND_PLURAL)
}
That way we won't need to change a lot of places where the old method already used and, more important, the old method is more convenient to use (and it is used relatively often from what I've seen in the changes).
The same is for other methods like getAllCheClusters
that are used often (however I see no point in such method for, say, deleteCheCluster
as it is used only once).
src/tasks/component-installers/devfile-workspace-operator-installer.ts
Outdated
Show resolved
Hide resolved
src/tasks/component-installers/devfile-workspace-operator-installer.ts
Outdated
Show resolved
Hide resolved
src/tasks/component-installers/devfile-workspace-operator-installer.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Flavius Lacatusu <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: flacatus, mmorhun, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
This PR remove remove Chemanager objects after executing server:delete command.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#19758
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.