fix: Fix build for s390x platform #394
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Nikitenko <[email protected]> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
|
Click here to review and test in web IDE: |
&message=Dev%20cluster%20(for%20maintainers)&logo=eclipseche&color=525C86&labelColor=FDB940)
|
Pull Request images published ✨ Editor: quay.io/che-incubator-pull-requests/che-code:pr-394-amd64 |
RomanNikitenko
commented
Aug 5, 2024
| https://rpmfind.net/linux/fedora-secondary/releases/34/Everything/s390x/os/Packages/l/libsecret-0.20.4-2.fc34.s390x.rpm \ | ||
| https://rpmfind.net/linux/fedora-secondary/releases/34/Everything/s390x/os/Packages/l/libsecret-devel-0.20.4-2.fc34.s390x.rpm"; \ | ||
| https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi8/8/s390x/baseos/os/Packages/l/libsecret-0.18.6-1.el8.s390x.rpm \ | ||
| https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi8/8/s390x/baseos/os/Packages/l/libsecret-devel-0.18.6-1.el8.s390x.rpm"; \ |
There was a problem hiding this comment.
I've added a new reference for the libsecret and libsecret-devel packages.
Build passed that step successfully - thanks a lot Sam Ding for testing it on the s390x platform!
Unfortunately, there is another error, related to xkbfile package:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes podman/docker build for
s390xplatformWhat issues does this PR fix?
eclipse-che/che#22998
How to test this PR?
Run podman/docker build for
ubi8andubi9assemblies.See https://github.com/che-incubator/che-code?tab=readme-ov-file#image-build
Does this PR contain changes that override default upstream Code-OSS behavior?
git rebasewere added to the .rebase folder=====================================
Signed-off-by: Roman Nikitenko [email protected]
rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED