-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Rebase against upstream #321
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #200409
Fix NPE in suggest
Add script for easy symlinking a local xterm repo
fixes #174768 fixes #127622
changing outputEditor to outputView
…n-expandable reference item. (#199996) * Fix the bug that pressing l key on non-expandable reference item shows error notification (with vim extension) * 💄 --------- Co-authored-by: João Moreno <[email protected]>
Signed-off-by: Shubh <[email protected]>
Fixes #201303
Fixes #199848
Fix sticky scroll showing up on first line
Fixes #199845
Add move terminal into new window action/menu item
Turns out all of these disposables were not getting cleaned up... but they really don't need to be disposables in this context. ref #201320
This way we have a consistent hover UI
* fix: memory leak in menubar * Update src/vs/base/browser/ui/menu/menubar.ts Co-authored-by: Benjamin Pasero <[email protected]> * Update src/vs/base/browser/ui/menu/menubar.ts Co-authored-by: Benjamin Pasero <[email protected]> * Update src/vs/base/browser/ui/menu/menubar.ts Co-authored-by: Benjamin Pasero <[email protected]> * fix: potential memory leak when focusing another menu --------- Co-authored-by: Benjamin Pasero <[email protected]> Co-authored-by: SteVen Batten <[email protected]>
vscode-upstream-sha1: 30b7773
Pull Request Dev image published: |
Pull Request Che-Code image published: |
RomanNikitenko
requested review from
azatsarynnyy,
vitaliy-guliy and
l0rd
as code owners
December 22, 2023 13:01
azatsarynnyy
approved these changes
Dec 22, 2023
Build 3.12 :: code_3.x/1141: Console, Changes, Git Data |
Build 3.12 :: sync-to-downstream_3.x/5744: Console, Changes, Git Data |
Build 3.12 :: get-sources-rhpkg-container-build_3.x/5616: code : 3.x :: Failed in 57766575 : BREW:BUILD/STATUS:UNKNOWN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rebase against the upstream
vscode-upstream-sha1: 30b7773
What issues does this PR fix?
eclipse-che/che#22745
How to test this PR?