Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rebase against upstream #321

Merged
merged 28 commits into from
Dec 22, 2023
Merged

chore: Rebase against upstream #321

merged 28 commits into from
Dec 22, 2023

Conversation

RomanNikitenko
Copy link
Contributor

What does this PR do?

Rebase against the upstream
vscode-upstream-sha1: 30b7773

What issues does this PR fix?

eclipse-che/che#22745

How to test this PR?

  • the jobs should be green
  • testing of any use cases is useful as we pick up a lot of commits from the upstream

lszomoru and others added 28 commits December 20, 2023 14:14
Fixes #200409
Add script for easy symlinking a local xterm repo
changing outputEditor to outputView
…n-expandable reference item. (#199996)

* Fix the bug that pressing l key on non-expandable reference item shows error notification (with vim extension)

* 💄

---------

Co-authored-by: João Moreno <[email protected]>
Fixes #199848
Fix sticky scroll showing up on first line
Add move terminal into new window action/menu item
Turns out all of these disposables were not getting cleaned up... but they really don't need to be disposables in this context.

ref #201320
* fix: memory leak in menubar

* Update src/vs/base/browser/ui/menu/menubar.ts

Co-authored-by: Benjamin Pasero <[email protected]>

* Update src/vs/base/browser/ui/menu/menubar.ts

Co-authored-by: Benjamin Pasero <[email protected]>

* Update src/vs/base/browser/ui/menu/menubar.ts

Co-authored-by: Benjamin Pasero <[email protected]>

* fix: potential memory leak when focusing another menu

---------

Co-authored-by: Benjamin Pasero <[email protected]>
Co-authored-by: SteVen Batten <[email protected]>
Copy link

github-actions bot commented Dec 22, 2023

Click here to review and test in web IDE: Contribute

Copy link

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-321-dev-amd64

Copy link

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-321-amd64

@RomanNikitenko RomanNikitenko marked this pull request as ready for review December 22, 2023 13:01
@RomanNikitenko RomanNikitenko merged commit ed8606c into main Dec 22, 2023
7 checks passed
@RomanNikitenko RomanNikitenko deleted the fix-rebase branch December 22, 2023 13:49
@devstudio-release
Copy link

Build 3.12 :: code_3.x/1141: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: get-sources-rhpkg-container-build_3.x/5616: FAILURE

code : 3.x :: Failed in 57766575 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.