Add remote settings.json to injector and copy it on start. #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add settings.json file (/remote/data/Machine/settings.json) to the injector, to be copied in to the checode volume on start. This settings.json file can be used to configure options for Code, taking precendence over user/in-browser settings, and can be used to set required configuration for running the code editor in Che. Signed-off-by: Angel Misevski <[email protected]>
amisevsk
requested review from
azatsarynnyy,
RomanNikitenko,
vitaliy-guliy and
l0rd
as code owners
|
Click here to review and test in web IDE: |
&message=Dev%20cluster%20(for%20maintainers)&logo=eclipseche&color=525C86&labelColor=FDB940)
|
Pull Request Dev image published: |
|
Pull Request Che-Code image published: |
RomanNikitenko
approved these changes
Nov 24, 2023
|
Build 3.11 :: code_3.x/1022: Console, Changes, Git Data |
|
Build 3.11 :: sync-to-downstream_3.x/5376: Console, Changes, Git Data |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR is a copy of #310 to avoid eclipse-che/che#22660; see original PR for discussion.
What does this PR do?
Add settings.json file (
/remote/data/Machine/settings.json) to the injector, to be copied in to the checode volume on start.This settings.json file can be used to configure options for Code, taking precendence over user/in-browser settings, and can be used to set required configuration for running the code editor in Che.
Currently, it is only used to set
"git.defaultCloneDirectory": "/projects/"What issues does this PR fix?
Closes eclipse-che/che#22653
How to test this PR?
I've pushed changes to
quay.io/amisevsk/che-code:dev. Updating a workspace's DevWorkspaceTemplate to reference this image instead of the default injector should result in file/checode/remote/data/Machine/settings.jsonexisting on start.If you use Code to clone a project, it should default the path to
/projects