Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the DevFile Commands by calling the che-terminal extension's API #123

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

azatsarynnyy
Copy link
Member

@azatsarynnyy azatsarynnyy commented Oct 3, 2022

Signed-off-by: Artem Zatsarynnyi [email protected]

What does this PR do?

  1. che-terminal extension exposes its API to get a vscode.Pseudoterminal that is passed to a Tasks's vscode.CustomExecution.
  2. Switches the che-commands extension to use che-terminal extension API when running the Devfile Commands.

This is step 2/3 in migrating from the current implementation of the machine-exec-based terminal, that replaces the built-in VS Code terminal, to the dedicated extension.
1/3 was introduced in #122.

What issues does this PR fix or reference?

Related to:

How to test this PR?

  1. Start a DevWorkspace with the test project https://github.com/azatsarynnyy/java-spring-petclinic/tree/commands-ext
  2. Try to run a Che Task. E.g.: Terminal > Run Task... > che.
  3. The task should be executed as expected, without any visible changes. Under the hood, the task is executed by calling the che-terminal extension's API. It can be verified by checking the Che Terminal output channel (View > Output).

@azatsarynnyy azatsarynnyy changed the title [WIP] Rely on che-terminal extension API when running DevFile Commands Run the DevFile Commands with the che-terminal extension's API Oct 5, 2022
@azatsarynnyy azatsarynnyy changed the title Run the DevFile Commands with the che-terminal extension's API Run the DevFile Commands by calling the che-terminal extension's API Oct 5, 2022
@azatsarynnyy azatsarynnyy marked this pull request as ready for review October 5, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants