This repository has been archived by the owner on Dec 5, 2020. It is now read-only.
Update configuration for the buildah #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitaliy Gulyy <[email protected]>
ericwill
suggested changes
Mar 3, 2020
etc/storage.conf
Outdated
|
|
||
| # Path to an helper program to use for mounting the file system instead of mounting it | ||
| # directly. | ||
| #mount_program = "/usr/bin/fuse-overlayfs" |
There was a problem hiding this comment.
If we are not using fuse-overlayfs it's probably best to remove this.
There was a problem hiding this comment.
I have copied the default configuration file and then changed necessary properties. I think it's a good practice, isn't it?
There was a problem hiding this comment.
But I'm also Ok to cleanup the file and left here only few lines.
There was a problem hiding this comment.
Let's keep it clean just for sake of consistency and making it easier to read.
Signed-off-by: Vitaliy Gulyy <[email protected]>
Signed-off-by: Vitaliy Gulyy <[email protected]>
Signed-off-by: Vitaliy Gulyy <[email protected]>
Signed-off-by: Vitaliy Gulyy <[email protected]>
ericwill
approved these changes
Mar 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vitaliy Gulyy [email protected]
Switches to the new stable buildah release.
Makes it possible to build the image inside running container.
Partially fixes eclipse-che/che#15035