Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

properly escape urls #28

Closed
chdsbd opened this issue Mar 18, 2019 · 4 comments
Closed

properly escape urls #28

chdsbd opened this issue Mar 18, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@chdsbd
Copy link
Owner

chdsbd commented Mar 18, 2019 •
edited
Loading

https://github.com/sublimehq/Packages/blob/master/C#/C#.sublime-syntax should be https://github.com/sublimehq/Packages/blob/master/C%23/C%23.sublime-syntax

test#? .,<>@!#$%^^&*()_+=":;?.,~`"'[{]}\|
=> 
test%23%3F%20.%2C%3C%3E%40!%23%24%25%5E%5E%26*()_%2B%3D%22:%3B%3F.%2C%7E%60%22'%5B%7B%5D%7D%5C%7C

related: ehamiter/GitHubinator#53

EDIT: I wanted to use vscode.Uri everywhere to fix this, but it seems that calling with({query: ...}) incorrectly applies encodeURIComponent on the string, which breaks the Gitlab provider for opening a URI. This issue could be fixed, but it's kind of a pain I don't think I'll touch it until I personally run into this issue.
@chdsbd chdsbd added the bug Something isn't working label Mar 18, 2019
@chdsbd
Copy link
Owner Author

chdsbd commented Mar 23, 2019

fixed in #29

@chdsbd chdsbd closed this as completed Mar 23, 2019
@chdsbd
Copy link
Owner Author

chdsbd commented Mar 23, 2019

This wasn't fixed 😞

@chdsbd chdsbd reopened this Mar 23, 2019
chdsbd added a commit that referenced this issue Apr 6, 2019
@chdsbd
revert: "fix(extension): escape file paths (#29)"
e66b1f1 
This reverts commit 6ca4d58.

GH-28 should resolve this issue completely
@chdsbd chdsbd mentioned this issue Apr 6, 2019
Merged
chdsbd added a commit that referenced this issue Apr 6, 2019
@chdsbd
revert: "fix(extension): escape file paths (#29)" (#31)
a870baf 
This reverts commit 6ca4d58.

GH-28 should resolve this issue completely
@chdsbd
Copy link
Owner Author

chdsbd commented Apr 17, 2021

related: microsoft/vscode#85930

@chdsbd
Copy link
Owner Author

chdsbd commented Apr 17, 2021

Fixed in #40

@chdsbd chdsbd closed this as completed Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chdsbd