fix(web_api): add type stubs for stripe #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest version of stripe type stubs are more filled out.
sbdchd
commented
Jun 4, 2022
| @@ -41,6 +41,9 @@ types-redis = "^0.1.10" | |||
| types-dj-database-url = "^0.5.0" | |||
| responses = "^0.21.0" | |||
| pytest-django = "^4.5.2" | |||
| types-stripe = "^2.59.10" | |||
| pydantic = "^1.9.1" | |||
| types-requests = "^2.27.30" | |||
There was a problem hiding this comment.
mypy no longer ships the typeshed so we need to specify what we want
sbdchd
commented
Jun 4, 2022
| @@ -15,7 +15,8 @@ | |||
| patch_django() | |||
|
|
|||
|
|
|||
| sentry_sdk.init(integrations=[DjangoIntegration()], send_default_pii=True) | |||
| # Waiting on https://github.com/getsentry/sentry-python/issues/1415 | |||
| sentry_sdk.init(integrations=[DjangoIntegration()], send_default_pii=True) # type: ignore[abstract] | |||
There was a problem hiding this comment.
waiting on getsentry/sentry-python#1415
sbdchd
commented
Jun 4, 2022
| @@ -41,6 +41,9 @@ types-redis = "^0.1.10" | |||
| types-dj-database-url = "^0.5.0" | |||
| responses = "^0.21.0" | |||
| pytest-django = "^4.5.2" | |||
| types-stripe = "^2.59.10" | |||
| pydantic = "^1.9.1" | |||
There was a problem hiding this comment.
updating due to mypy issue: pydantic/pydantic#3528
sbdchd
commented
Jun 4, 2022
| @@ -24,7 +24,7 @@ pywatchman = "^1.4" | |||
| [tool.poetry.dev-dependencies] | |||
| pylint = "^2.4" | |||
| pytest = "6.0.1" | |||
| mypy = "^0.812" | |||
| mypy = "^0.960" | |||
There was a problem hiding this comment.
updated so mypy understandings type[T]
chdsbd
approved these changes
Jun 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest version of stripe type stubs are more filled out and provide some useful type checking:
python/typeshed#7978