Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support podAnnotations for web and worker deployments #97

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Support podAnnotations for web and worker deployments #97

merged 2 commits into from
Mar 22, 2023

Conversation

nickmonad
Copy link
Contributor

@nickmonad nickmonad commented Mar 21, 2023 •
edited
Loading

Allows the user to specify custom pod annotations for the web and worker deployments. This is useful for things like linkerd injection, or whatever else the user might need.

I didn't add this to the migrations Job spec, not sure if it makes sense there. Could always use another values.yaml key if desired.

vishnu-narayanan
vishnu-narayanan approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@vishnu-narayanan vishnu-narayanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickmonad Thank you for the PR.

@vishnu-narayanan vishnu-narayanan merged commit b030454 into chatwoot:main Mar 22, 2023
@nickmonad nickmonad deleted the pod-annotations branch March 22, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishnu-narayanan vishnu-narayanan vishnu-narayanan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickmonad @vishnu-narayanan