Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move @types to devDependencies #8

Closed
wants to merge 1 commit into from

Conversation

ntindall
Copy link

This causes issues for some versions of npm-shrinkwrap.

@jjrv
Copy link
Member

jjrv commented Apr 29, 2017

Hi,

thanks for the PR! What sort of issues do you refer to? The @types are in dependencies for cases where cxml is used in a TypeScript project. Its type definitions depend on others, so all required types need to be installed when using the package.

@jjrv
Copy link
Member

jjrv commented Apr 29, 2017

See microsoft/types-publisher#81

@ntindall
Copy link
Author

I see. I was not aware that types-publisher advocates --save. We should close this as the root cause (scoped packages) is a known issue with npm-shrinkwrap.

@ntindall ntindall closed this May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants