-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to enable both wheel and drag modes at the same time #507
Conversation
Nice! |
Oh you're right, I admit that I often forget to check touch behaviors. Do I add |
I think Edit: Other option would be to add a warning when |
@kurkle I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two very minor comments. Looks great!
Hi,
Here is a PR thats adds the ability to enable both wheel and drag modes at the same time, as suggested in #239. I propose to split the wheel/drag configurations like this:
speed
,threshold
,wheelModifierKey
(nowwheel.modifierKey
) are moved to their respective configurations, I think that makes clearer that a given option refers to a given mode.