Feature: Zoom each scale separately #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurkle
reviewed
Mar 9, 2021
lirik90
force-pushed
the
master
branch
2 times, most recently
from
62fde44 to
b9646dc
Compare
|
Hi, @kurkle . I tried to add a comment, please see it. |
|
Thanks, the code looks good to me now. Would you be able to create a test for it? |
Added the overScaleMode option so that you can use zoom and pan separately for each scale when the mouse is over the scale.
|
I added two small tests. Are they enough? |
kurkle
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the overScaleMode option so that you can use zoom and pan separately for each scale when the mouse is over the scale.
Try it: https://codepen.io/lirik90/pen/rNLqMVg
Or watch what is it: https://youtu.be/u3HlB3YX_fs