Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate that SubTitle is a plugin in TS types #9386

Merged
merged 2 commits into from
Jul 10, 2021
Merged

Indicate that SubTitle is a plugin in TS types #9386

merged 2 commits into from
Jul 10, 2021

Conversation

etimberg
Copy link
Member

@etimberg etimberg commented Jul 9, 2021

May be related to #9383

@etimberg etimberg added the type: types Typescript type changes label Jul 9, 2021
@etimberg etimberg added this to the Version 3.5.0 milestone Jul 9, 2021
@LeeLenaleee
Copy link
Collaborator

Shouldn't there also be SubTitle options too or does it take the Title options since you use the Title plugin as a basis?

@etimberg etimberg linked an issue Jul 9, 2021 that may be closed by this pull request
Module '"chart.js"' has no exported member 'SubTitle'. #9383
Closed
@etimberg
Copy link
Member Author

etimberg commented Jul 9, 2021

You're right @LeeLenaleee. I've added that

@etimberg etimberg requested a review from kurkle July 10, 2021 12:10
@kurkle kurkle merged commit 6ab2e8c into chartjs:master Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
type: types Typescript type changes
Projects
None yet
Milestone
Version 3.5.0
Development

Successfully merging this pull request may close these issues.

Module '"chart.js"' has no exported member 'SubTitle'.
3 participants
@etimberg @LeeLenaleee @kurkle