Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix rollup external moment #7587

Merged
merged 1 commit into from
Jul 5, 2020
Merged

docs: fix rollup external moment #7587

merged 1 commit into from
Jul 5, 2020

Conversation

mojoaxel
Copy link
Contributor

@mojoaxel mojoaxel commented Jul 5, 2020 •
edited
Loading

benmccann
benmccann approved these changes Jul 5, 2020
View reviewed changes
Copy link
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine to me. we might as well merge it. though i'm not sure it will ever get released because i'm not sure we'll be doing another 2.9 release

@mojoaxel
Copy link
Contributor Author

mojoaxel commented Jul 5, 2020

though i'm not sure it will ever get released because i'm not sure we'll be doing another 2.9 release

No problem I'm also really really waiting for the v3 release 😉

@etimberg etimberg merged commit 679ec4a into chartjs:2.9 Jul 5, 2020
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request May 12, 2021
Open
@martinakraus martinakraus mentioned this pull request Jun 5, 2024
Closed
@jaimeperez-vs jaimeperez-vs mentioned this pull request Jun 18, 2024
Open
This was referenced Aug 16, 2024
Open
Open
This was referenced Sep 8, 2024
Open
Open
This was referenced Sep 14, 2024
Open
Open
Open
Open
Open
@ryanmichaelfabayos ryanmichaelfabayos mentioned this pull request Sep 20, 2024
Open
@luisgarciaxygeni luisgarciaxygeni mentioned this pull request Sep 28, 2024
Open
@saadi1995 saadi1995 mentioned this pull request Oct 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@benmccann benmccann benmccann approved these changes

Assignees
No one assigned
Labels
type: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mojoaxel @benmccann @etimberg