Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add normalizedData option #6767

Closed
wants to merge 1 commit into from
Closed

Conversation

benmccann
Copy link
Contributor

Closes #6765

@kurkle
Copy link
Member

kurkle commented Nov 19, 2019

I think splitting to linear and series time scales would remove the need for this option (for the series version), wouldn't it? I'm missing something probably, it should be done with the distribution option already if it is so.

@benmccann
Copy link
Contributor Author

Why do you say splitting the scale would remove the need for the option? I think it'd still be necessary, but might be missing something

I think this option is only necessary for series mode, which seems to be the opposite of what you're suggesting? In series mode we need to know which index a give x value is at. The indexes need to be unique, sorted, and consistent in order to do so

@kurkle
Copy link
Member

kurkle commented Nov 19, 2019

Oh, right. I meant for linear its not needed and for series we could require data to be normalized. I can't think of a use case with non-normalized data that one would want to plot in series

@benmccann
Copy link
Contributor Author

Closing in favor of #6775

@benmccann benmccann closed this Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to specify dataset has been normalized
2 participants