Align title, body and footer inside tooltip #5925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurkle
force-pushed
the
#1977
branch
2 times, most recently
from
5a9c430
to
bf81391
Compare
benmccann
reviewed
Dec 19, 2018
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nagix
reviewed
Dec 26, 2018
|
The code looks good to me. Can you add unit tests? I think tests using mock context are suitable for this. |
nagix
previously approved these changes
Dec 29, 2018
etimberg
previously approved these changes
Jan 6, 2019
simonbrunel
reviewed
Jan 7, 2019
simonbrunel
reviewed
Jan 7, 2019
|
Requested (and more) changes. Follow label.align pattern from #3175 (comment) (with imaginary |
nagix
approved these changes
Jan 8, 2019
etimberg
approved these changes
Jan 8, 2019
|
Thanks @kurkle |
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master: https://codepen.io/kurkle/pen/WLoZPK
This PR: https://codepen.io/kurkle/pen/GPNvra (65ef3b0)
Fixes #1977