-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typos and broken links in the documents #5010
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, I would just rename the "Ratio" section to "Pixel Ratio"
docs/SUMMARY.md
Outdated
@@ -7,6 +7,7 @@ | |||
* [Usage](getting-started/usage.md) | |||
* [General](general/README.md) | |||
* [Responsive](general/responsive.md) | |||
* [Ratio](general/device-pixel-ratio.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would call this section "Pixel Ratio" since there is also "Aspect Ratio" detailed in the Responsive section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @simonbrunel
Respond to changes request
I renamed the "Ratio" section to "Pixel Ratio". Thank you for the quick reviews. 😄 |
Thanks @beiz23 |
docs/general/device-pixel-ratio.md
indocs/SUMMARY.md
, since users could not reach the document on device-pixel-ratio.