Issue #2252, added usePointStyle option to allow label boxes to match… #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o match the shape(pointStyle) of the corresponding data.
| @@ -52,6 +52,7 @@ module.exports = function(Chart) { | |||
| lineJoin: dataset.borderJoinStyle, | |||
| lineWidth: dataset.borderWidth, | |||
| strokeStyle: dataset.borderColor, | |||
| pointStyle: dataset.pointStyle, | |||
There was a problem hiding this comment.
We should document this in Legend Item Interface section of 01-Chart-Configuration.md
|
+1 to merge. @slinhart nothing jumped out at me while looking at this. |
|
This looks awesome (assuming it works as defined), but could you please fix that merge conflict @slinhart? |
Conflicts: src/core/core.legend.js
|
@zachpanz88 merged 😁 |
|
Looks good to me! Very cool! |
|
Do these merged commits on pull requests ever require the version number be bumped? I was previously using the npm version of chart.js and it is also version 2.1.6, but doesn't include the changes in this issue. |
|
@neilmonroe this will be included in the next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution to this issue: #2252
New option added: options.legend.labels.usePointStyle (Boolean)
When true, legend "boxes" will be drawn in the same shape as the pointStyle specified for the data.
Simple screenshot for clarity.
