Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change react integration test to TS #10605

Merged
merged 6 commits into from
Aug 18, 2022

Conversation

LeeLenaleee
Copy link
Collaborator

Improve the change in catching TS errors like #10599

etimberg
etimberg previously approved these changes Aug 17, 2022
@etimberg etimberg requested a review from kurkle August 17, 2022 22:45
kurkle
kurkle previously approved these changes Aug 18, 2022
test/integration/react-browser/src/App.tsx Outdated Show resolved Hide resolved
test/integration/react-browser/src/AppAuto.tsx Outdated Show resolved Hide resolved
@LeeLenaleee LeeLenaleee dismissed stale reviews from kurkle and etimberg via d6637b7 August 18, 2022 11:37
@etimberg etimberg merged commit 49b16c9 into chartjs:master Aug 18, 2022
@LeeLenaleee LeeLenaleee deleted the improve-integration-test branch August 18, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants