Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support from focal to noble #214

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Adding support from focal to noble #214

wants to merge 6 commits into from

Conversation

addyess
Copy link
Member

@addyess addyess commented Jul 12, 2024 •
edited
Loading

Overview

To support running on noble and jammy while still building/running on focal update python charm libaries

Details

  • Update metadata to support noble
  • Block out any resources or charm files built in the local path
  • Adding wheelhouse.txt to update charms.reactive and setuptools
  • Fix issues with testing in an upgraded tox envrionment
  • Fix issues with updated charm-tools to support noble
  • Map to corrected inclusive naming checks

@addyess addyess force-pushed the akd/noble-support branch from 235fc56 to e8cb5ad Compare July 12, 2024 16:16
@addyess addyess force-pushed the akd/noble-support branch from e8cb5ad to 909c01f Compare July 12, 2024 17:16
@addyess

This comment was marked as outdated.

Sign in to view
@addyess addyess mentioned this pull request Jul 25, 2024
Closed
kwmonroe
kwmonroe reviewed Jul 26, 2024
View reviewed changes
Copy link
Contributor

@kwmonroe kwmonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the spirit of this; need to investigate the CI failure before merging.

@addyess addyess marked this pull request as ready for review July 26, 2024 20:46
@addyess addyess marked this pull request as draft July 26, 2024 20:47
@addyess addyess marked this pull request as ready for review December 19, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwmonroe kwmonroe kwmonroe left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addyess @kwmonroe