Stop listening on 127.0.0.1:4001 with http #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwmonroe
approved these changes
Sep 21, 2023
Co-authored-by: Kevin W Monroe <[email protected]>
addyess
added a commit
that referenced
this pull request
Sep 22, 2023
* Upgrade tests to juju 3.1 * Update test_etcd.py use model destroy_unit() * Stop listening on 127.0.0.1:4001 with http (#212) * Stop listening on 127.0.0.1:4001 with http * Ensure the restore action uses the secure endpoint as well * linting * Update config.yaml Co-authored-by: Kevin W Monroe <[email protected]> --------- Co-authored-by: Kevin W Monroe <[email protected]> --------- Co-authored-by: Kevin W Monroe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to address a security concern with etcd, we should stop listening on port 4001 (http) and instead only use the more secure
https://127.0.0.1:2379for charm configuration. If the admin wishes to expose 4001 -- they may do so only on the localhost with a new charm config optionbind_with_insecure_http.This PR merges into a branch where I've upgraded the charm to use juju 3.1 for integration testing
bind_with_insecure_httpto allow the user to enable if wanted