feat: color conversion utilities for (hsv, rgb, and hex) #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meowgorithm
force-pushed
the
color
branch
5 times, most recently
from
8f6ed56
to
bb9237f
Compare
|
missing run ./scripts/dependabot
./scripts/buildsto setup dependabot and GitHub actions |
|
|
||
| // ColorToHex converts a color to a hex string. | ||
| func ColorToHex(c color.Color) string { | ||
| r, g, b, _ := c.RGBA() |
There was a problem hiding this comment.
Needs a nil check
Suggested change
| r, g, b, _ := c.RGBA() | |
| if c == nil { | |
| return "" | |
| } | |
| r, g, b, _ := c.RGBA() |
| // - The hue will be rounded to the nearest degree, while the saturation and | ||
| // value will be rounded to two decimal places. | ||
| func ColorToHSV(c color.Color) (h, s, v float64) { | ||
| r, g, b, _ := c.RGBA() |
There was a problem hiding this comment.
Suggested change
| r, g, b, _ := c.RGBA() | |
| if c == nil { | |
| return 0, 0, 0 | |
| } | |
| r, g, b, _ := c.RGBA() |
| c color.Color | ||
| want string | ||
| }{ | ||
| {color.RGBA{0, 0, 0, 255}, "#000000"}, |
There was a problem hiding this comment.
Suggested change
| {color.RGBA{0, 0, 0, 255}, "#000000"}, | |
| {nil, ""}, | |
| {color.RGBA{0, 0, 0, 255}, "#000000"}, |
| h, s, v float64 | ||
| } | ||
| }{ | ||
| {color.RGBA{0, 0, 0, 255}, struct{ h, s, v float64 }{0, 0, 0}}, |
There was a problem hiding this comment.
Suggested change
| {color.RGBA{0, 0, 0, 255}, struct{ h, s, v float64 }{0, 0, 0}}, | |
| {nil, struct{ h, s, v float64 }{0, 0, 0}}, | |
| {color.RGBA{0, 0, 0, 255}, struct{ h, s, v float64 }{0, 0, 0}}, |
|
Appreciate the review. Yeah, after putting this together it occurred to me that go-colorful is probably a better choice. If it ends up doing what I need it to, I’ll close this PR without merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functions for converting to and from HSV.
There's also a color to hexadecimal conversion for convenience.