fix(record): propagate env of vhs process to record terminal #572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pr broke env variables propagation to terminal spawned by record command.
From Env description
Appending
VHS_RECORD
makes it not nil, so it resets env. This pr fixes #554.For example with the latest released vhs
The simplest solution is to get env of the main process and then append
VHS_RECORD
The same example with the build from this PR
Let me know if you see a better solution.