New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint issues #285

Merged

maaslalani merged 2 commits into master from unparam

Mar 2, 2024

Contributor

maaslalani commented Mar 2, 2024

fix(lint): cascadeStyles always passed true
fix(lint): gomnd

maaslalani added 2 commits

March 2, 2024 15:02


          fix(lint): cascadeStyles always passed true

add9aa4


          fix(lint): gomnd

65d9926

maaslalani requested a review from muesli as a code owner

March 2, 2024 20:06

maaslalani commented

View reviewed changes

ansi/style.go

@@ @@ -138,11 +138,11 @@ type StyleConfig struct { @@
               	HTMLSpan  StyleBlock `json:"html_span,omitempty"`
               }
-              func cascadeStyles(toBlock bool, s ...StyleBlock) StyleBlock {
+              func cascadeStyles(s ...StyleBlock) StyleBlock {

Contributor Author

maaslalani Mar 2, 2024

@muesli Feel free to revert these changes if they're necessary for the future

maaslalani merged commit 61945ee into master

18 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet