Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autolink element is not displayed #290

Closed
Hugo-C opened this issue Mar 17, 2024 · 0 comments · Fixed by #317
Closed

Autolink element is not displayed #290

Hugo-C opened this issue Mar 17, 2024 · 0 comments · Fixed by #317
Assignees
Labels
bug Something isn't working

Comments

@Hugo-C
Copy link

Hugo-C commented Mar 17, 2024

Hello,
I spotted an issue when running glow on https://github.com/novuhq/novu/blob/next/SECURITY.md.
It turns out emails/urls inside strong like in:

are not displayed at all. Strikethrough and italic are also affected.

I have dabbled a crude fix in Hugo-C@2b5be5e but I wonder if the root cause could be from goldmark where AutoLink.Text returns nothing and we are then forced to call URL() or Label() on it ?

caarlos0 added a commit that referenced this issue Jul 16, 2024
caarlos0 added a commit that referenced this issue Jul 16, 2024
Signed-off-by: Carlos Alexandro Becker <[email protected]>
@caarlos0 caarlos0 self-assigned this Jul 16, 2024
@caarlos0 caarlos0 added the bug Something isn't working label Jul 16, 2024
bashbunni added a commit that referenced this issue Jul 31, 2024
* wip

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* wip

* wip

* wip

* fix: autolink

closes #290

* fix: escape characters

closes #106
closes #274
closes #311

* fix: table

* ci: golangci lint update

* feat: use x/golden

* test: #106

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* test: #290

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* test: #312

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* test: #257

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* test: #149

* fix: #239

* feat: use lipgloss table

closes #262

Co-authored-by: bashbunni <[email protected]>

* fix: codespan is not a block

* test: #315

* test: #316

* fix: #316

* test: table

* fix: codespans, tables

* test: table

* test: #117

* test: #60

* fix: rm stylewriter

* fix: #313

* fix: margin

* fix: blocks and word wrap

* fix: build

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* chore: gitattributes

* fix: test opt

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* fix: stable lipgloss

Signed-off-by: Carlos Alexandro Becker <[email protected]>

* fix: double styles

* fix: tables

* fix: tables

---------

Signed-off-by: Carlos Alexandro Becker <[email protected]>
Co-authored-by: bashbunni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants