-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve FS and speed up file opening #134
Open
aymanbagabas
wants to merge
19
commits into
main
Choose a base branch
from
fs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
force-pushed
the
fs
branch
2 times, most recently
from
May 4, 2022 18:51
25f4417
to
337f1b1
Compare
caarlos0
approved these changes
May 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nicely done!
aymanbagabas
force-pushed
the
fs
branch
5 times, most recently
from
May 5, 2022 17:45
2ad127a
to
a29699e
Compare
implement fs.StatFS and make use of sysFuture
aymanbagabas
force-pushed
the
fs
branch
2 times, most recently
from
May 10, 2022 00:41
53840a5
to
6c9058f
Compare
error when file does not exist and dir is not empty
* ignore file info name * refactor: change storage.Stat to storage.Info * ignore the underlying fs file permissions and use the metadata ones * use a sane dmode & fmode permissions (777 & 666)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
X-*
headers to pass file info when downloading/uploading files (server & client)/v1/fs/*
HEAD request to fetch file info (server)