Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop renderer before acquiring renderer mutex #757

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Conversation

muesli
Copy link
Contributor

@muesli muesli commented Jun 2, 2023

Fixes #741.

@muesli muesli added the bug Something isn't working label Jun 2, 2023
collinvandyck added a commit to collinvandyck/gpterm that referenced this pull request Jun 4, 2023
@muesli muesli merged commit 44f17fa into master Jun 5, 2023
@muesli muesli deleted the shutdown-lock branch June 5, 2023 08:05
renovate bot referenced this pull request in sheldonhull/az-pr Jun 12, 2023
…ea to v0.24.2 (#20)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/charmbracelet/bubbletea](https://togithub.com/charmbracelet/bubbletea)
| require | patch | `v0.24.1` -> `v0.24.2` |

copilot:all

---

### Release Notes

<details>
<summary>charmbracelet/bubbletea</summary>

###
[`v0.24.2`](https://togithub.com/charmbracelet/bubbletea/releases/tag/v0.24.2)

[Compare
Source](https://togithub.com/charmbracelet/bubbletea/compare/v0.24.1...v0.24.2)

This point release fixes a race condition that could occur when stopping
the default renderer:

- fix: stop renderer before acquiring mutex by
[@&#8203;muesli](https://togithub.com/muesli) in
[https://github.com/charmbracelet/bubbletea/pull/757](https://togithub.com/charmbracelet/bubbletea/pull/757)

**Full Changelog**:
charmbracelet/bubbletea@v0.24.1...v0.24.2

***

<a href="https://charm.sh/"><img alt="The Charm logo"
src="https://stuff.charm.sh/charm-badge.jpg" width="400"></a>

Thoughts? Questions? We love hearing from you. Feel free to reach out on
[Twitter](https://twitter.com/charmcli), [The
Fediverse](https://mastodon.social/@&#8203;charmcli), or
[Discord](https://charm.sh/chat).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/sheldonhull/az-pr).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bubbletea app hangs when quitting about 10% of the time.
1 participant