feat(table): add function to set cursor position #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikaro
added a commit
to nikaro/zabbixmon
that referenced
this pull request
Aug 20, 2022
Change submitted upstream charmbracelet/bubbles#219
maaslalani
reviewed
Aug 21, 2022
| @@ -291,6 +291,12 @@ func (m Model) Cursor() int { | |||
| return m.cursor | |||
| } | |||
|
|
|||
| // SetCursor sets the cursor position in the table. | |||
| func (m *Model) SetCursor(n int) { | |||
There was a problem hiding this comment.
I wonder if MoveTo is a better name, to match MoveUp and MoveDown.
There was a problem hiding this comment.
I used SetCursor since it matches with Cursor and the others Set* methods, and it literally sets the cursor attribute :-) But it's up to you, i don't have a preference on this, let me know if you want me to amend the commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow to (re)set the cursor position after the table is updated.