Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kebab-case public event names #807

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tumes
Copy link

@tumes tumes commented Feb 27, 2020

I've submitted precious few PRs to other projects, so please excuse me if I'm unfamiliar with the process.

I was using your wonderful datepicker on a project when I noticed that the public event names don't adhere to Vue's guidelines and thus the Vue dev tools complain at you if you try to use them. I went ahead and modified them, plus retained camel-cased versions of the old events so it's not quite so jarring a change.

I imagine there are some non-public events that may also need updating, put I don't have a tremendous amount of time this afternoon, my apologies 🙇

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling baff4bd on tumes:kebab-event-names into de0fc75 on charliekassel:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants