Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP https://peps.python.org/pep-0484/#the-numeric-tower
says there are issues with this numbers module.
In less formal places you can find python core maintainers (including Guido, the inventor of Python) saying that the numbers module was a mistake and you shouldn't use it.
You can always put an instance of
int
where afloat
belongs. So in most cases, you can usefloat
for typing instead ofnumbers.Number
.For
isinstance
, it won't see anint
as afloat
, so you canisinstance(n, (float, int))
If you find some other use case where that doesn't work, the official recommendation is to make a
typing.Protocol
specific for your use case.for more information:
python/typing#272
python/mypy#3186
microsoft/pyright#1575