Bulk allocations #125
Merged
Bulk allocations #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any spec run before base_spec.rb doesn't gain the benefits of base_spec running `Chargify.configure` and therefore doesn't have a site URI.
|
🎄 🎅 👍 |
|
Strange bundler failures on travis. Not sure what's up there as I didn't change anything in the Gemfile or gemspec. |
|
There I fixed it ;-) |
|
🌟 |
|
@speric Can I get a |
?
|
@ryansch yes! |
|
Looks good to me |
|
Thanks for adding! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Chargify::Allocations.bulk_createto work with https://docs.chargify.com/api-allocations#create-multiple-allocations.I didn't explicitly require the use of json when calling this method but I'd be open to putting a guard at the top.
I also fixed a bug in the test suite where we were relying on the side effects of calling
Chargify.configureinbase_spec.rb.