Push and pull 'nightly' tag Docker images in nightly test job #25619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riftEmber
changed the title
riftEmber
force-pushed
the
test-docker-nightly
branch
2 times, most recently
from
f532e32 to
ee0c010
Compare
Also adjusts the gasnet and gasnet-smp Dockerfiles to build off of the Chapel base image's nightly tag (rather than latest) so they use the just-built result. Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Dashes not underscores... Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
riftEmber
force-pushed
the
test-docker-nightly
branch
from
1c9f6a9 to
e2b1613
Compare
I think #25637 already addressed the case difference issue |
Ah, that explains why my last rebase skipped my commit doing the same thing 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the nightly Docker testing script to push (and pull)
nightlytags of the images.This incidentally makes the chapel-gasnet and chapel-gasnet-smp images build off of the just-built Chapel base image. Previously it was building off of the
latesttag from the last release, not accessing the local copy oflatestdue to behavior of the buildx builder.While here, adjust formatting of
util/cron/test-docker.bashscript for clarity.Resolves https://github.com/Cray/chapel-private/issues/6436.
[reviewer info placeholder]
Testing:
nightlyimages on chapelmac-m1nightlytag