Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed minor typos #641

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Fixed minor typos #641

merged 1 commit into from
Apr 8, 2020

Conversation

ria18405
Copy link
Contributor

@ria18405 ria18405 commented Apr 5, 2020

Fixed minor spelling errors in README and backend.py
Signed-off-by: Ria Gupta [email protected]

@coveralls
Copy link

coveralls commented Apr 5, 2020

Coverage Status

Coverage remained the same at 97.765% when pulling b9fc31c on ria18405:master into 27bda3a on chaoss:master.

@valeriocos valeriocos self-requested a review April 6, 2020 06:14
Copy link
Member

@valeriocos valeriocos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you you @ria18405 for the PR. Can you improve the commit description by adding some text about the files modified?

The test for Python 3.5 are failing due to this error:

      File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/setuptools/sandbox.py", line 195, in setup_context
        yield
      File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/setuptools/sandbox.py", line 250, in run_setup
        _execfile(setup_script, ns)
      File "/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/setuptools/sandbox.py", line 44, in _execfile
        code = compile(script, filename, 'exec')
      File "/tmp/easy_install-9qmvxszx/pandoc-2.0a4/setup.py", line 11
        error = f"pip is not installed, refer to <{url}> for instructions."
                                                                          ^
    SyntaxError: invalid syntax

Can you have a look at this problem?
It may be due to the way Python is installed, since in tests for Python 3.6 no errors are thrown (see below).

  • Python 3.6
$ git clone --depth=50 https://github.com/chaoss/grimoirelab-perceval.git chaoss/grimoirelab-perceval
0.01s0.00s$ source ~/virtualenv/python3.6/bin/activate
$ python --version
Python 3.6.7
$ pip --version
pip 19.0.3 from /home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/pip (python 3.6)
before_install.1
12.03s$ pip install -r "requirements.txt"
before_install.2
1.25s$ pip install -r "requirements_tests.txt"
before_install.3
1.03s$ pip install flake8
before_install.4
1.74s$ pip install coveralls
install
2.08s$ pip install .
12.48s$ flake8 .
  • Python 3.5
Downloading archive: https://storage.googleapis.com/travis-ci-language-archives/python/binaries/ubuntu/16.04/x86_64/python-3.5.tar.bz2
0.64s$ curl -sSf --retry 5 -o python-3.5.tar.bz2 ${archive_url}
10.52s$ sudo tar xjf python-3.5.tar.bz2 --directory /
0.00s
git.checkout
0.90s$ git clone --depth=50 https://github.com/chaoss/grimoirelab-perceval.git chaoss/grimoirelab-perceval
0.01s0.00s$ source ~/virtualenv/python3.5/bin/activate
$ python --version
Python 3.5.6
$ pip --version
pip 18.1 from /home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/pip (python 3.5)
before_install.1
13.08s$ pip install -r "requirements.txt"
before_install.2
1.35s$ pip install -r "requirements_tests.txt"
before_install.3
1.15s$ pip install flake8
before_install.4
1.88s$ pip install coveralls
0.97s$ pip install .

Thanks!

@ria18405
Copy link
Contributor Author

ria18405 commented Apr 6, 2020

Hi @valeriocos ,

I could not generate this error on my local machine.

  • For 'pip not installed', I downloaded and set up a python3.5 virtual environment with pip version pip 20.0.2 from /home/ria/venv3.5/lib/python3.5/site-packages/pip (python 3.5)
  • For failure of python setup.py egg_info", I upgraded setuptools.
  • While running pip install . I get a successful build message :
Successfully built perceval
Installing collected packages: perceval
Successfully installed perceval-0.13.0

What could be the problem?

@valeriocos
Copy link
Member

valeriocos commented Apr 6, 2020

Hi @ria18405 ,

Maybe it's the pip version, in python 3.6 is pip 19.0.3 and no errors are thrown, while for python is pip 18.1 and there are errors.

Try to repeat what you did here #641 (comment), but using that pip version. If the error appears, you can create a new PR that modifies the before_install section to upgrade the pip version.

Thanks!

@ria18405 ria18405 force-pushed the master branch 2 times, most recently from 585ea24 to c2c648b Compare April 6, 2020 17:15
@ria18405
Copy link
Contributor Author

ria18405 commented Apr 7, 2020

Hi @valeriocos
Upgrading the pip version didnt help in the travis tests for python3.5. Although again, locally I'm getting a successful installation, and all tests run perfectly - Ran 956 tests in 151.722s. What can I do to resolve this?

@valeriocos
Copy link
Member

Hi @ria18405, the same error appears also on this PR: chaoss/grimoirelab-elk#833.

Can you work together with @animeshk08 to solve it?

@animeshk08
Copy link
Contributor

Sure @valeriocos I am on it!

@valeriocos
Copy link
Member

Thanks!

@animeshk08
Copy link
Contributor

Hi @ria18405. try upgrading setup tools in travis.yml. Add the below line to before_install section:
pip install --upgrade setuptools

I am not quite sure why this has happened but based on a bit of hunch and this answer I believe the trouble was with linking of setup tools with pip. Sorry, I could not find a good reference. Let me know how it goes :)

\cc @valeriocos

@animeshk08 animeshk08 mentioned this pull request Apr 8, 2020
@ria18405
Copy link
Contributor Author

ria18405 commented Apr 8, 2020

Hi @animeshk08

Thanks for the suggestion, I stumbled on a similar reference earlier and upgraded setuptools in my local tests, but didn't add it in travis.yml. I'll try to follow that. Hope it works! Thanks :)

@ria18405
Copy link
Contributor Author

ria18405 commented Apr 8, 2020

Hi @valeriocos
The PR is ready for review.
Thanks

@valeriocos
Copy link
Member

Thank you @ria18405 , can you rebase your PR, the branch isn't aligned with master.

If upstream is the original repo https://github.com/chaoss/grimoirelab-perceval, you can do:

git fetch upstream
git rebase upstream/master

This commit fixes typos in README and backend.py

Signed-off-by: Ria Gupta <[email protected]>
@valeriocos valeriocos closed this in 4173398 Apr 8, 2020
@valeriocos valeriocos merged commit 4173398 into chaoss:master Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants