Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refectroign: Error return function modification #1029

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

yj-yoo
Copy link
Contributor

@yj-yoo yj-yoo commented Apr 17, 2024

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

- Replaced errors.New(fmt.Sprintf()) with fmt.Errorf().
  According to the following blog,
  fmt.Errorf() is recommended for errors that require formatting,
  and errors.New() is recommended if the error text cannot be changed.
  ref: https://www.digitalocean.com/community/tutorials/how-to-add-extra-information-to-errors-in-go

Signed-off-by: Youngjun <[email protected]>
@MandssS MandssS added this to the v1.7.4 milestone Jul 3, 2024
@MandssS MandssS merged commit abae755 into chaosblade-io:master Jul 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants