fix: Disk burn experiment failed in Kubernetes #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RCA : different version of dd command between different Linux release version. link: https://github.com/chaosblade-io/chaosblade-exec-os/issues/93 Signed-off-by: kelvin Guo <[email protected]>
|
@xcaspar could you help to review the PR? |
xcaspar
approved these changes
Aug 4, 2021
xcaspar
added
type/bug
|
@kelvinguo0210 Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RCA : different version of dd command between different Linux release version.
link: https://github.com/chaosblade-io/chaosblade-exec-os/issues/93
Describe what this PR does / why we need it
This modification mainly adds some conditions to determine the appropriate dd command parameters for different Linux versions (right now is Alpine Linux)
Does this pull request fix one issue?
Fixes #93
Describe how you did it
This modification mainly adds some conditions to determine the appropriate dd command parameters for different Linux versions (right now is Alpine Linux)
Describe how to verify it
Tested in local UAT kubernetes Env.
Special notes for reviews
At the time, the main branch was not be able to be compiled, the error is from system_stop.go, please take a look.
My real test is base on v1.2.0.