Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fixes #97

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Build fixes #97

merged 4 commits into from
Mar 6, 2024

Conversation

snogge
Copy link
Contributor

@snogge snogge commented Mar 6, 2024

  1. There was a missing , in an AS_CASE in configure.ac
  2. scripts/Makefile.am in did not handle separated source and build directories. Replace the local rules with Automake declarations. This will create the required install, uninstall, and clean operations.
  3. Update the m4-files copied from autoconf-archive. Just because I could.

@snogge
Copy link
Contributor Author

snogge commented Mar 6, 2024

There is a problem with the use of ax_lua.m4. It does not support cross compilation.
I did a workaround that I will eventually contribute to meta-virtualization where I used pkg-config to read lua version and such. But the lua.pc file is an OpenEmbedded thing and is not part of the regular lua releases.
Not sure how to handle it more generally.

Copy link
Member

@garlick garlick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - thanks! I'll merge once CI finishes.

I don't have any great ideas on the lua question....

@garlick garlick merged commit 937fbb2 into chaos:master Mar 6, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants