Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has not been tested on dev yet. Due to the python3.7 requirement introduced in v1.50 an upgrade on our dev host (Ubuntu 18.04 LTS, python 3.6) requires more time than I have right now. However, prod is running on Debian 10 / python 3.7 that is fine. I would strongly prefer testing this before rolling the update out to production. However, after reading the upgrade notes I do not see any significant difficulties coming. Depending on how you see it, I think we could give directly going to production a try (Of course doing proper procedure with backups before hand and making synapse unreachable until we are assured that nothing obvious broke).
From reading the change log / upgrade notes, those changes seem as if they could affect us (but in the end don't).
- Deprecation of the ability to delegate e-mail verification to identity servers: Should not affect us (I think) due to our usage of SSO
- Possibility for failing migrations if the database is corrupted and has duplicates: We should be fine since we don't appear to have any dupes (on prod, not tested on dev):
- Python 3.7 and PostgresQL 10+ requirement: Fine in prod, dev runns on Python 3.6