Deck reports init container failure

Part of kubernetes#20816
chaodaiG · Feb 11, 2021 · 5d68278 · 5d68278
1 parent 2c107b0
commit 5d68278
Show file tree

Hide file tree

Showing 3 changed files with 65 additions and 3 deletions.
diff --git a/prow/spyglass/lenses/metadata/lens.go b/prow/spyglass/lenses/metadata/lens.go
@@ -234,8 +234,25 @@ func hintFromPodInfo(buf []byte) string {
 		}
 	}
 
-	// We've got nothing.
-	return ""
+	// There are cases where initContainers failed to start
+	var msg string
+	for _, ic := range report.Pod.Status.InitContainerStatuses {
+		if ic.Ready {
+			continue
+		}
+		// Init container not ready by the time this job failed
+		// The 3 different states should be mutually exclusive, if it happens
+		// that there are more than one, use the most severe one
+		if state := ic.State.Terminated; state != nil {
+			msg = fmt.Sprintf("state: terminated, reason: %q, message: %q", state.Reason, state.Message)
+		} else if state := ic.State.Waiting; state != nil {
+			msg = fmt.Sprintf("state: waiting, reason: %q, message: %q", state.Reason, state.Message)
+		} else if state := ic.State.Running; state != nil { // This shouldn't happen at all, just in case.
+			logrus.WithField("pod", report.Pod.Name).WithField("container", ic.Name).Warning("Init container is running but not ready")
+		}
+		msg = fmt.Sprintf("Init container %s not ready: (%s)", ic.Name, msg)
+	}
+	return msg
 }
 
 func hintFromProwJob(buf []byte) (string, bool) {

diff --git a/prow/spyglass/lenses/metadata/lens_test.go b/prow/spyglass/lenses/metadata/lens_test.go
@@ -326,6 +326,52 @@ func TestHintFromPodInfo(t *testing.T) {
 				},
 			},
 		},
+		{
+			name:     "init container failed to start",
+			expected: "Init container initupload not ready: (state: terminated, reason: \"Error\", message: \"failed fetching oauth2 token\")",
+			info: k8sreporter.PodReport{
+				Pod: &v1.Pod{
+					ObjectMeta: metav1.ObjectMeta{
+						Name: "8ef160fc-46b6-11ea-a907-1a9873703b03",
+					},
+					Spec: v1.PodSpec{
+						Containers: []v1.Container{
+							{
+								Name:  "test",
+								Image: "gcr.io/k8s-testimages/kubekins-e2e:v20200428-06f6e3b-master",
+							},
+						},
+					},
+					Status: v1.PodStatus{
+						Phase: v1.PodPending,
+						InitContainerStatuses: []v1.ContainerStatus{
+							{
+								Name:  "initupload",
+								Ready: false,
+								State: v1.ContainerState{
+									Terminated: &v1.ContainerStateTerminated{
+										Reason:  "Error",
+										Message: "failed fetching oauth2 token",
+									},
+								},
+							},
+						},
+						ContainerStatuses: []v1.ContainerStatus{
+							{
+								Name:  "test",
+								Image: "gcr.io/k8s-testimages/kubekins-e2e:v20200428-06f6e3b-master",
+								Ready: false,
+								State: v1.ContainerState{
+									Waiting: &v1.ContainerStateWaiting{
+										Reason: "PodInitializing",
+									},
+								},
+							},
+						},
+					},
+				},
+			},
+		},
 	}
 
 	for _, tc := range tests {

diff --git a/prow/test/integration/fakeghserver/BUILD.bazel b/prow/test/integration/fakeghserver/BUILD.bazel
@@ -29,7 +29,6 @@ go_library(
         "//prow/interrupts:go_default_library",
         "//prow/logrusutil:go_default_library",
         "//prow/pjutil:go_default_library",
-        "@com_github_google_go_github//github:go_default_library",
         "@com_github_gorilla_mux//:go_default_library",
         "@com_github_sirupsen_logrus//:go_default_library",
     ],