fix: load SparseDatasets into memory #898
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change
Anndata has a special class
SparseDataset
when loading a file to memory to reduce memory consumption. Unfortunately the data we need is not accesible from that class and needs to be loaded into memory before performing spatial validation, otherwise the following error occurs.Changes
_to_backed
is not being used because it causes a different error further down in the code and eventually lead to loading the sparse matrix into memory any ways.Testing
Notes for Reviewer
After this is merged a we will need to apply the changes made in 5.0.3 and release 5.0.4. The changes in 5.0.3 must be reversed before releasing 5.1.0.