fix: CL_0002494 cell subclass term #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #779 +/- ##
==========================================
- Coverage 84.35% 84.29% -0.06%
==========================================
Files 19 19
Lines 1898 1898
==========================================
- Hits 1601 1600 -1
- Misses 297 298 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Bento007
approved these changes
Feb 16, 2024
Bento007
added a commit
to chanzuckerberg/cellxgene-ontology-guide
that referenced
this pull request
Mar 15, 2024
## Reason for Change - #15 ## Changes - add script to generate descendant mapping. It's based off a script in [single-cell-curation](https://github.com/chanzuckerberg/single-cell-curation/blob/main/scripts/compute_mappings/compute_tissue_and_cell_type_mappings.py) - update GHA to install the local API to run generate descendant mapping. ## Testing steps - Added test cases - Compared to tissue_descendants.json and cell_type_descendant.json generating by the single-cell-curation repo. Results: - verified PR is auto generated for decendant mapping updates #116 - Add GHA run every monday at midnight, by workflow_dispatch, or if the ontology assets are updated ``` ------Comparing Ontology Guide and single-cell-curation Cell Type Descendant KEYS: In Ontology Guide not in single-cell-curation {'CL:4030031'} DESCENDANT: In Ontology Guide not in single-cell-curation CL:0000738 {'CL:2000054'} CL:0002320 {'CL:0002554'} CL:0002319 {'CL:4033051', 'CL:4033052'} CL:0000117 {'CL:4033051', 'CL:4033052'} CL:0000057 {'CL:0002554'} CL:0000540 {'CL:4033051', 'CL:4033052'} CL:0000219 {'CL:2000054'} CL:0000542 {'CL:2000054'} CL:0000988 {'CL:2000054'} KEYS: In single-cell-curation not in Ontology Guide None DESCENDANT: In single-cell-curation not in Ontology Guide ``` ## Notes for Reviewer - Terms in the locally generated cell_type_descendants.json not in cellxgene_schema/cell_type_descendants.json - `CL:4030031`: [interstitial cell](https://www.ebi.ac.uk/ols4/ontologies/cl/classes/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252FCL_4030031) - `CL:0002494`: [cardiocyte](https://www.ebi.ac.uk/ols4/ontologies/cl/classes/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252FCL_0002494) was recently added to chanzuckerberg/single-cell-data-portal#6756 and chanzuckerberg/single-cell-curation#779. Not sure why it isn't showing up in the old version of the descendant mapping script. --------- Co-authored-by: github-actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes CL_0002494 from cell class to cell subclass https://czi-sci.slack.com/archives/C023Q1APASK/p1708047974696449?thread_ts=1707952513.995039&cid=C023Q1APASK